next »

[Jan S.]

Hi,

I am trying to upload a file from Android client to Genero server using HTTP.
The multipart content of the HTTP request contains the only one single part with jpg image. There is no other body or file part.

My HTTP POST request looks like:

POST http://172.16.6.27:8090/upload HTTP/1.1
Host: 172.16.6.142:8888
User-Agent: Dalvik/1.6.0 (Linux; U; Android 4.0.4; sdk Build/MR1)
Accept-Encoding: gzip, deflate
Connection: keep-alive
Accept: */*
Content-Type: multipart/form-data; boundary=----------------------------2a708b2baf25414eb7f47c63975a07b2
Content-Length: 22141

------------------------------2a708b2baf25414eb7f47c63975a07b2
Content-Disposition: form-data; name="IMG_20140529_103509.jpg"; filename="IMG_20140529_103509.jpg"

... data ...
------------------------------2a708b2baf25414eb7f47c63975a07b2--


Server 4gl code:

Code

IMPORT com
IMPORT xml
 
MAIN
  DEFINE req        com.HTTPServiceRequest
  DEFINE url        STRING
  DEFINE method     STRING
  DEFINE doc        xml.DomDocument
  DEFINE type       STRING
  DEFINE ind        INTEGER
  DEFINE p          com.HTTPPart
  DEFINE resp       STRING
  DEFINE i          INTEGER
 
  DISPLAY "START"
  CALL com.WebServiceEngine.Start()
 
  LET req = com.WebServiceEngine.getHTTPServiceRequest(-1)
  LET url = req.getURL()
  DISPLAY url
  IF url IS NULL  THEN
    DISPLAY "Failed: url should not be null"
    EXIT PROGRAM (-1)    
  END IF
 
  LET method = req.getMethod()
  DISPLAY "method: ", method
  IF method IS NULL OR method != "POST" THEN
    DISPLAY "Failed: method should be POST"
  END IF
 
  # Check multipart type
  LET type = req.getRequestMultipartType()
  DISPLAY "type: ", type
  IF type IS NULL THEN
    DISPLAY "Failed: expected multipart in request"
  END IF
 
  # Process additional parts
  LET resp = "count: ", req.getRequestPartCount()
  DISPLAY resp
 
  FOR ind = 1 TO req.getRequestPartCount()
    LET p = req.getRequestPart(ind)
    IF p.getAttachment() IS NOT NULL THEN
      LET resp = resp, " att: ", p.getAttachment()
      DISPLAY "Attached file at :",p.getAttachment()
    ELSE
      LET resp = resp, " content: ", p.getContentAsString()
      DISPLAY "Attached part is :",p.getContentAsString()
    END IF
  END FOR
 
  CALL req.sendTextResponse(200, "", resp)
 
END MAIN

But in the Genero I'm still getting request part count = 0.
Am I missing something?

Thanks

Jan

[Frank G.]

Hi,

  when you have only one part, it is considered as the main part and must be handled with the method req.readDataRequest().

Something like following :

  DEFINE b BYTE
  # Check multipart
  ...
  LOCATE b IN MEMORY
  CALL srv.readDataRequest(b)
  ...
  b.writeFile("myfile.jpg")


And all other parts will then be available via the getRequestPart() and getRequestPartCount().

Frank.

[Jan S.]

Thanks for your reply.

However, now for the same requests, program on method call req.readDataRequest(b) is throwing these exceptions:

FORMS statement error number -15549.
HTTP runtime exception : Unexpected end of multipart protocol.

FORMS statement error number -15549.
HTTP runtime exception : Mulitpart protocol error 1.

Jan

[Frank G.]

Hi,

  I reproduced the issue and filed a new bug #GWS-442 : Reading a 'form-data' multipart response where first part contains a Content-Disposition header does not work.

 Sorry for the inconvenience

Frank

[Frank G.]

Hi,

  As workaround, you can add a main part of type text in your HTML formular (maybe as hidden), and send as second part the file.
See attached sample.

Hope it helps
Frank

[Jan S.]

Hi,

request posted from your html form is processed correctly.
But when I'm posting similar request with "hack" part from my Android client I'm getting another error, still on calling req.readDataRequest(b):

FORMS statement error number -15549.
HTTP runtime exception : No valid header on HTTP request..

Headers seem to be OK, if I get them by the req.getRequestHeaderValue() method and display to console before reading data part.

The request is attached.

Jan

[Frank G.]

I did not reproduce with the workaround.zip test case on Android. I'm a bit confused, you say that you get an error on readDataRequest(), but this method is not called in my workaround test case.  Can you please clarify ?

Notice that I used Chrome as browser on Android, do you have another browser or a dedicated client app ?

Thanks

[Jan S.]

Hi,

sorry for your confusion. I tried various modifications. In your workaround case program fails on readTextRequest() with the same error message "HTTP runtime exception : No valid header on HTTP request..".

I'm sending request from my own native Android test app using Ion library (https://github.com/koush/ion) for networking.

my test upload method:

Code

    public void uploadFile(String url, String filePath){
        File file = new File(filePath);
        Log.d(LOG_TAG, "exist: " + file.exists());
 
        Future<Response<String>> uploading;
        Response<String> response = null;
        try {
            uploading = Ion.with(this)
                    .load("POST", url)
                    .setTimeout(3000)
                    .setHeader("Connection", "Keep-Alive")
                    .setMultipartParameter("hack", "")
                    .setMultipartFile(file.getName(), file)
                    .asString()
                    .withResponse();
            response = uploading.get();
            if (response != null){
                Log.d(LOG_TAG, "result: " + response.getResult());
            } else {
                Log.d(LOG_TAG, "response null");
            }
        } catch (Exception e) {
            Toast.makeText(this, "error: " + e.getLocalizedMessage(), Toast.LENGTH_LONG).show();
        }
    }

Jen

[Frank G.]

Hi,

  Sorry but I'm not able to reproduce. I did a dedicated android app using the Ion library and your code sample, but I'm still able to communicate with the FGL server.

  Could you maybe retry and set FGLWSDEBUG=3 before starting the fglrun server.

Thanks,
Frank

[Jan S.]

Hi,

I set FGLWSDEBUG=3 according to your advice.

output:


WS-DEBUG (Receive)
POST /upload HTTP/1.1
WS-DEBUG END


WS-DEBUG (Receive)
Host: chsrv07.vera.local:8090
User-Agent: Dalvik/1.6.0 (Linux; U; Android 4.4.2; sdk Build/KK)
Accept-Encoding: gzip, deflate
Accept: */*
Connection: Keep-Alive
Content-Type: multipart/form-data; boundary=----------------------------8ae7246c4b534bc8bbabd1440aa66de2
Content-Length: 26011

WS-DEBUG END

http://chsrv07.vera.local:8090/upload
method: POST
type: form-data

WS-DEBUG (Receive)
------------------------------8ae7246c4b534bc8bbabd1440aa66de2\r\nContent-Disposition: form-data; name="hack"\r\n\r\n
WS-DEBUG END


WS-DEBUG (Receive)
\r\n
WS-DEBUG END


WS-DEBUG (Receive)
------------------------------8ae7246c4b534bc8bbabd1440aa66de2\r\nContent-Disposition: form-data; name="IMG_20140905_024752.jpg"; filename="IMG_20140905_024752.jpg"\r\n\r\n
WS-DEBUG END


WS-DEBUG (IO ERROR)
Class: HTTPHeader::readMultipart()
Msg: No valid header on HTTP request.
Code: 0
WS-DEBUG END


WS-DEBUG (HTTP ERROR)
Class: HTTPMultipartParser
Msg: No valid header on HTTP request.
WS-DEBUG END

Program stopped at 'MultipartServer.4gl', line number 45.
FORMS statement error number -15549.
HTTP runtime exception : No valid header on HTTP request..



Jan

[Jan S.]

Hi,

until now I has been testing upload only with a program running in standalone mode. It's little strange that it works with various clients except Ion. Now I tried to deploy the MultipartServer program on the GAS. Through the GAS upload is working now even with a client using Ion library!

Thanks for your support Frank.

Jan